#20 Seeking a little insight into why this code is commented out

Closed
opened 6 years ago by jimmy · 1 comments
Jimmy commented 6 years ago
#for port in $(cat files/ports/whitelist)
#do
#	if grep "^$port-" $PATCH_DIR/INDEX || grep "/$port||" $PATCH_DIR/INDEX
#	then
#		echo "OK" > /dev/null
#	else
#		echo "$port" >> files/ports/blacklist
#		linedel "/$port " INDEX
#		echo "$port has a non-free depedency-- it has been added to the blacklist."
#		echo "You'll have to re-run this script in order to apply this change."
#		sleep 2
#	fi
#done

I'm just wondering why this code is commented out, my use of git blame suggests this was written by my favourite bash wizard @jadedctrl

``` #for port in $(cat files/ports/whitelist) #do # if grep "^$port-" $PATCH_DIR/INDEX || grep "/$port||" $PATCH_DIR/INDEX # then # echo "OK" > /dev/null # else # echo "$port" >> files/ports/blacklist # linedel "/$port " INDEX # echo "$port has a non-free depedency-- it has been added to the blacklist." # echo "You'll have to re-run this script in order to apply this change." # sleep 2 # fi #done ``` I'm just wondering why this code is commented out, my use of git blame suggests this was written by my favourite bash wizard @jadedctrl
Jaidyn Ann commented 6 years ago
Owner

IIRC, I commented it out because it doesn't work, and brings up a ton of false-flags. I put it in my mental to-do-later pile, jaja. The data from the old ports deblob script (used for 5.9/6.0 tree; files/ports/[black|white]list) are still valid and up-to-date, so it isn't important that this be fixed right now-- although it really needs to be at some point.

IIRC, I commented it out because it doesn't work, and brings up a ton of false-flags. I put it in my mental to-do-later pile, jaja. The data from the old ports deblob script (used for 5.9/6.0 tree; files/ports/[black|white]list) are still valid and up-to-date, so it isn't important that this be fixed right now-- although it really needs to be at some point.
Sign in to join this conversation.
No Label
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.