review-1.5.txt 1.1 KB

123456789101112131415161718192021222324
  1. Review Alexandru 2008-05-08
  2. ===========================
  3. [X] Regarding feature request #8529 (a du -s implementation). The documentation
  4. for ezcBaseFile::findRecursive() says that you can supply an empty array
  5. as the 4th argument to get the statistics.
  6. If I pass for example $stats which I initialized with array() before, then
  7. I get notices: "Undefined index: count in /home/as/dev/ezcomponents/trunk/Base/src/file.php
  8. on line 139", and the same notice for index "size".
  9. Also the documentation does not mention that you need to pass a variable and not
  10. a value - if I pass array() as the 4th argument I get the error "Cannot pass
  11. parameter 4 by reference"
  12. If I pass $stats which I initialize with null, false or empty string before,
  13. then the function works.
  14. Also all the file recursive tests fail on Windows (slash issues mostly).
  15. [X] Regarding feature request #11506 (method ezcBase::getInstallationPath()). On
  16. Linux it returns the path without any slash at the end, but on Windows (Vista)
  17. it adds a Windows slash at the end.