#44 Markdown parser and monospace text

Open
opened 3 years ago by pharpend · 8 comments

First of all, if I use the "four space" method to make monospace text, gogs shouldn't highlight it:

In addition to the highlighting, gogs is removing line breaks. Here is the source for that:

There seem to be a lot of bugs in the markdown parser. How difficult would it be to switch to a different one?

First of all, if I use the "four space" method to make monospace text, gogs shouldn't highlight it: ![](https://a.pomf.se/phgevh.png) In addition to the highlighting, gogs is removing line breaks. Here is the source for that: ![](https://a.pomf.se/vrltag.png) There seem to be a lot of bugs in the markdown parser. How difficult would it be to switch to a different one?
i commented 3 years ago

There are quite a lot. I don't know about how hard it would be to switch, but I don't think this is the right place. You should probably report to either https://github.com/russross/blackfriday or https://github.com/gogits/gogs if you haven't already done so, because nab gogs still pulls from the official gogs repository.

There are *quite* a lot. I don't know about how hard it would be to switch, but I don't think this is the right place. You should probably report to either https://github.com/russross/blackfriday or https://github.com/gogits/gogs if you haven't already done so, because nab gogs still pulls from the official gogs repository.

I'll have a look, it may not be so hard to switch out the parser actually.

Do you have a suggestion for a particular markdown parser written in go?

I'll have a look, it may not be so hard to switch out the parser actually. Do you have a suggestion for a particular markdown parser written in go?
Peter Harpending commented 3 years ago
Poster

@hp If there's a go port of Haskell's Pandoc, I would recommend that. Other than that, no. I'm not a go programmer, so I don't know the libraries well.

@hp If there's a go port of Haskell's Pandoc, I would recommend that. Other than that, no. I'm not a go programmer, so I don't know the libraries well.
zPlus commented 1 year ago

This is very likely a fixed issue now. The markdown parser is using monospace, and it doesn't seem to highlight text when using four spaces.

Line breaks also seem to be working fine.

I think this issue can be closed, but @pharpend please feel free to report again if you still see some bugs.

This is very likely a fixed issue now. The markdown parser is using monospace, and it doesn't seem to highlight text when using four spaces. Line breaks also seem to be working fine. I think this issue can be closed, but @pharpend please feel free to report again if you still see some bugs.
zPlus commented 11 months ago

I suggest this issue be closed. The markdown parser seems to me a lot better now than it was originally. If there are other parsing errors, I think it's a better idea to open a new issue.

I suggest this issue be closed. The markdown parser seems to me a lot better now than it was originally. If there are other parsing errors, I think it's a better idea to open a new issue.
probs commented 7 months ago

This still seems to be an issue.

Example: https://notabug.org/splat/splat/src/master/license.md

This still seems to be an issue. Example: https://notabug.org/splat/splat/src/master/license.md
zPlus commented 7 months ago

OFFTOPIC @probs NotABug is not meant to host non-free projects, as it is described here. I think the best thing to do would be to consider a different license for the project, for example CC-BY-SA, otherwise the project could be removed.

`OFFTOPIC` @probs NotABug is not meant to host non-free projects, as it is described [here](https://notabug.org/tos). I think the best thing to do would be to consider a different license for the project, for example CC-BY-SA, otherwise the project could be removed.
probs commented 7 months ago

@zPlus, thanks for the heads up. My intent was to keep it in the spirit of free software, while also guaranteeing that the user can access it freely. While this may not exactly comport with the FSF's notion of free software, I hope you'll find it does fit a more general notion of free software (one with the end user's interests in mind). If that's not acceptable I understand and will look for someplace else to host it. We can discuss it further in the issue tracker for that project if you like: splat/splat#1

@zPlus, thanks for the heads up. My intent was to keep it in the spirit of free software, while also guaranteeing that the user can access it freely. While this may not exactly comport with the FSF's notion of free software, I hope you'll find it does fit a more general notion of free software (one with the end user's interests in mind). If that's not acceptable I understand and will look for someplace else to host it. We can discuss it further in the issue tracker for that project if you like: https://notabug.org/splat/splat/issues/1
Sign in to join this conversation.
No Milestone
No assignee
5 Participants
Loading...
Cancel
Save
There is no content yet.