#39 Image hosting

Open
opened 4 years ago by pharpend · 4 comments

If I report an issue on GitHub, and embed an image from another domain, like this:

GitHub moves the image to its own domain. I imagine it does this in case the other site goes down. Should Gogs do this as well?

If I report an issue on GitHub, and embed an image from another domain, like this: ![](https://a.pomf.se/lvikpp.png) GitHub moves the image to its own domain. I imagine it does this in case the other site goes down. Should Gogs do this as well?
i commented 4 years ago

Probably not. I think this mainly depends on disk space. Github has basically infinite (for all intents and purposes), so they can probably afford to automatically set this up and do it.

I don't really see a problem with linking to (or hotlinking) to images hosted somewhere else, and I think it's somewhat out of scope for nab. Just use a 'reliable' image host.

Just my 2c though of course.

Probably not. I think this mainly depends on disk space. Github has basically infinite (for all intents and purposes), so they can probably afford to automatically set this up and do it. I don't really see a problem with linking to (or hotlinking) to images hosted somewhere else, and I think it's somewhat out of scope for nab. Just use a 'reliable' image host. Just my 2c though of course.
zPlus commented 2 years ago

@pharpend can you check this again please? The new Gogs version has a "Drop files here" box for each comment. I'm not sure if this answers your question.

@pharpend can you check this again please? The new Gogs version has a "Drop files here" box for each comment. I'm not sure if this answers your question.
zPlus commented 1 year ago

Just testing with a link

Just testing with a link ![](https://lut.im/3B80ZTSwNP/VgQn9q8hbZYQ8AS0.png)
zPlus commented 1 year ago

OK this is not fixed because the image is still fetched from the external domain. There is however a "drop files here" box to attach files to a commit, so I'd personally consider this fixed.

OK this is not fixed because the image is still fetched from the external domain. There is however a "drop files here" box to attach files to a commit, so I'd personally consider this fixed.
Sign in to join this conversation.
No Milestone
No assignee
3 Participants
Loading...
Cancel
Save
There is no content yet.