#184 commits file count is limited

Open
opened 2 months ago by milisarge · 8 comments

when i look at a commit's changed files (e.g pull requests), it doesnt show more than 10?

e.g https://notabug.org/milislinux/imaj-uretici/pulls/1/files

here is a response from gogs side:

https://github.com/gogs/gogs/issues/5350

when i look at a commit's changed files (e.g pull requests), it doesnt show more than 10? e.g https://notabug.org/milislinux/imaj-uretici/pulls/1/files here is a response from gogs side: https://github.com/gogs/gogs/issues/5350
cage commented 2 months ago

Hello!

so they suggest to increase: MAX_GIT_DIFF_FILES, right?

Bye! C.

Hello! so they suggest to increase: `MAX_GIT_DIFF_FILES`, right? Bye! C.
Milis Linux commented 2 months ago
Poster

yes in conf/app.ini. it seems that will solve. btw repo's MAX_GIT_DIFF_FILES value is 100. hmm maybe at your server's app.ini value is different ?

yes in conf/app.ini. it seems that will solve. btw repo's MAX_GIT_DIFF_FILES value is 100. hmm maybe at your server's app.ini value is different ?
cage commented 2 months ago

Hi!

Well i do know the value of that variable on this instance of gogs because i am just an (happy :-) ) user, not an admin. I find the limits of files shown quite annoying too, but please understand that this low limits may (probably) be used to keep the hardware/network resources used acceptable (i mean low enough).

Bye! C.

Hi! Well i do know the value of that variable on this instance of gogs because i am just an (happy :-) ) user, not an admin. I find the limits of files shown quite annoying too, but please understand that this low limits may (probably) be used to keep the hardware/network resources used acceptable (i mean low enough). Bye! C.
Milis Linux commented 2 months ago
Poster

Yes it is really issue for us, can't it re-consider to increase?

Yes it is really issue for us, can't it re-consider to increase?
zPlus commented 2 months ago

The value should be already set to 100. @hp can you please look in the server config if there is the same value or if it was changed? You should find this variable MAX_GIT_DIFF_FILES in /conf/app.ini. Thanks.

[The value should be already set to 100](https://notabug.org/hp/gogs/src/master/conf/app.ini#L402). @hp can you please look in the server config if there is the same value or if it was changed? You should find this variable `MAX_GIT_DIFF_FILES` in `/conf/app.ini`. Thanks.

IIRC the number of diffs rendered was reduced intentionally because some bots were crippling the system through the tor channel - i think this is a trade-off for allowing tor access - so in order to render entire diffs again the tor channel would need to be closed

IIRC the number of diffs rendered was reduced intentionally because some bots were crippling the system through the tor channel - i think this is a trade-off for allowing tor access - so in order to render entire diffs again the tor channel would need to be closed
cage commented 2 months ago

Well if this is the reason i think is a valid one.

I mean, i can see the point keeping that limit at 10.

Bye! C.

Well if this is the reason i think is a valid one. I mean, i can see the point keeping that limit at 10. Bye! C.
Milis Linux commented 2 months ago
Poster

hmm, well how are other git servers handle this issue for bots. please reconsider because of we are using notabug as primary git server to push-pull updates. this is important us (for Milis Linux team)

hmm, well how are other git servers handle this issue for bots. please reconsider because of we are using notabug as primary git server to push-pull updates. this is important us (for Milis Linux team)
Sign in to join this conversation.
No Milestone
No assignee
4 Participants
Loading...
Cancel
Save
There is no content yet.