#140 Bottom links in home page not 'clickable'

Closed
opened 4 months ago by cage · 6 comments
cage commented 4 months ago

Hello!

Seems that the bottom links ("NotABug.org is a Peers Community project", "NotABug.org is powered by a liberated version of gogs") are no more clickable.

Appears to me that the problem could be in the z-index: -1 of the css id #home-footer-div

Bye!

C.

Hello! Seems that the bottom links ("NotABug.org is a _Peers Community_ project", "NotABug.org is powered by a _liberated_ version of _gogs_") are no more clickable. Appears to me that the problem could be in the `z-index: -1` of the css id `#home-footer-div` Bye! C.
zPlus commented 4 months ago

Rather than changing the z-index, I think a better fix is to remove the position: fixed from the #home-footer-div class and add some margin-bottom: ...

Rather than changing the `z-index`, I think a better fix is to remove the `position: fixed` from the `#home-footer-div` class and add some `margin-bottom: ...`
cage commented 4 months ago
Poster

Hello!

Sorry but maybe i gave the impression that changing the value of z-index would be a good solution for the issue, it is not or, more exactly, i do not know! :-) Mine was only a suggestion for a starting point! :-)

But if you ask my opinion i would add the content of #home-footer-div too <footer> toggling dynamically its content (for example if user is logged or not).

But this are just my random thought! :)

Bye!

C.

Hello! Sorry but maybe i gave the impression that changing the value of `z-index` would be a good solution for the issue, it is not or, more exactly, i do not know! :-) Mine was only a suggestion for a starting point! :-) But if you ask my opinion i would add the content of `#home-footer-div` too `<footer>` toggling dynamically its content (for example if user is logged or not). But this are just my random thought! :) Bye! C.

patched in #141

ty @cage

patched in #141 ty @cage
zPlus commented 3 days ago

This is now fixed thanks to @bill-auger patch. All links are clickable. The homepage still isn't rendered nicely on smaller screens though.

This is now fixed thanks to @bill-auger patch. All links are clickable. The homepage still isn't rendered nicely on smaller screens though.
hp closed 3 days ago

btw - i expected this issue to close automatically due to the commit message: "restore-home-page (fixes #140)"

btw - i expected this issue to close automatically due to the commit message: "restore-home-page (fixes #140)"
The homepage still isn't rendered nicely on smaller screens though.

i just noticed this too - in my original PR i made all elements "responsive" except for the top navbar - but it is only the "register" and "sign in" buttons that are unreachable and those are both duplicated in the main content div so i did not bother with those - im not sure what happened since then to make the same code non-responsive now

that particular commit is now the HEAD of the 'responsive' branch on my fork https://notabug.org/bill-auger/gogs/src/responsive

The homepage still isn't rendered nicely on smaller screens though. i just noticed this too - in my original PR i made all elements "responsive" except for the top navbar - but it is only the "register" and "sign in" buttons that are unreachable and those are both duplicated in the main content div so i did not bother with those - im not sure what happened since then to make the same code non-responsive now that particular commit is now the HEAD of the 'responsive' branch on my fork https://notabug.org/bill-auger/gogs/src/responsive
Sign in to join this conversation.
No Milestone
No assignee
3 Participants
Loading...
Cancel
Save
There is no content yet.