You opened this pull request and closed it some seconds after that.
I see two options now:
You closed it by mistake and want me to merge it
You found a bug in your fix and don't want me to merge it
Could you please tell me which one is correct?
And if this fix is correct,did you also test it with instances on subdomains like social.example.com?
I think that's why it checked for two dots in the domain name and it's important that fixing it for top level domains doesn't break it for subdomains.
You opened this pull request and closed it some seconds after that.
I see two options now:
- You closed it by mistake and want me to merge it
- You found a bug in your fix and don't want me to merge it
Could you please tell me which one is correct?
And if this fix is correct,did you also test it with instances on subdomains like social.example.com?
I think that's why it checked for two dots in the domain name and it's important that fixing it for top level domains doesn't break it for subdomains.
Niklas Poslovski
You opened this pull request and closed it some seconds after that. I see two options now:
Could you please tell me which one is correct? And if this fix is correct,did you also test it with instances on subdomains like social.example.com? I think that's why it checked for two dots in the domain name and it's important that fixing it for top level domains doesn't break it for subdomains.
i closed it because i realized that it was already fixed by commit
fde3eefada. sorry.