#55 Load News and Aushänge sections from DSB

Closed
opened 4 years ago by fynngodau · 31 comments

(Not to be confused with the DSBDirect news system.)

DSB has a "News" and an "Aushänge" section schools can use. DSBDirect should implement them as well. (For an example how this is intended, log in with the demo credentials 187801 / public.)

Nobody asked for this, ever, so it has very low priority.

(Not to be confused with the DSBDirect news system.) DSB has a "News" and an "Aushänge" section schools can use. DSBDirect should implement them as well. (For an example how this is intended, log in with the demo credentials `187801 / public`.) Nobody asked for this, ever, so it has very low priority.

I'm working on this issue.

I'm working on this issue.

I hope using Kotlin instead of Java it won't be a problem for you.

I hope using Kotlin instead of Java it won't be a problem for you.

@fynngodau Could you have a look at https://gitlab.com/JasMich.de/___Direct/tree/information-board ? Would you like to merge it? It's not perfect yet (the scale and size of the images) but it works...

@fynngodau Could you have a look at https://gitlab.com/JasMich.de/___Direct/tree/information-board ? Would you like to merge it? It's not perfect yet (the scale and size of the images) but it works...

Done (what was mentioned on GitLab). Could you merge?

Done (what was mentioned on GitLab). Could you merge?
fynngodau commented 4 years ago
Owner

Is there a reason you are starting the NoticeBoard activity using startActivityForResult(new Intent(MainActivity.this, NoticeBoard.class), REQUEST_LOGIN);? If I'm not mistaken, this will lead to the app exiting on a non-debug build if the result code is RESULT_CANCELLED (which is 0, which it is by default) due to this code in onActivityResult(…):

if (resultCode == RESULT_CANCELED && requestCode == REQUEST_LOGIN) {
    // Login was cancelled, quit if not debug
    if (getResources().getBoolean(R.bool.authenticate_quit_on_cancel))
        finish();
}
Is there a reason you are starting the `NoticeBoard` activity using ` startActivityForResult(new Intent(MainActivity.this, NoticeBoard.class), REQUEST_LOGIN);`? If I'm not mistaken, this will lead to the app exiting on a non-debug build if the result code is `RESULT_CANCELLED` (which is 0, which it is by default) due to this code in `onActivityResult(…)`: ``` if (resultCode == RESULT_CANCELED && requestCode == REQUEST_LOGIN) { // Login was cancelled, quit if not debug if (getResources().getBoolean(R.bool.authenticate_quit_on_cancel)) finish(); } ```

Isn't this only about MainActivity?

(I did what you proposed on the font size in news cards. But unlike you I moved the Notice Board button to the main menu. You need to decide what you prefer.)

Isn't this only about MainActivity? (I did what you proposed on the font size in news cards. But unlike you I moved the Notice Board button to the main menu. You need to decide what you prefer.)
fynngodau commented 4 years ago
Owner

Your implementation looks the same as mine does except for its icon, whereas the icon you are using doesn't look Material (where is it from?) and it is always shown, even if no news are available.

You now have inconsistent font size between news card and notice card; I have removed the distinction between these two layouts in my fork because the cards are so similar, as this avoids duplicate code and allows recycling the convertView in NoticeAdapter.getView(int, View, ViewGroup) to reduce lag when scrolling.

By the way, in my fork, I have restyled the cards to use the specifications that I once got from the Material Design guidelines, which I think looks better than the current design.

Isn't this only about MainActivity?

I'm uncertain what you are referring to; the method openNoticeBoard() you wrote that contained the code I asked about (in specific, startActivityForResult(new Intent(MainActivity.this, NoticeBoard.class), REQUEST_LOGIN);) is part of MainActivity, yes.

Your implementation looks the same as mine does except for its icon, whereas the icon you are using doesn't look Material (where is it from?) and it is always shown, even if no news are available. You now have inconsistent font size between news card and notice card; I have removed the distinction between these two layouts in my fork because the cards are so similar, as this avoids duplicate code and allows recycling the `convertView` in `NoticeAdapter.getView(int, View, ViewGroup)` to reduce lag when scrolling. By the way, in my fork, I have restyled the cards to use the specifications that I once got from the Material Design guidelines, which I think looks better than the current design. > Isn't this only about MainActivity? I'm uncertain what you are referring to; the method `openNoticeBoard()` you wrote that contained the code I asked about (in specific, `startActivityForResult(new Intent(MainActivity.this, NoticeBoard.class), REQUEST_LOGIN);`) is part of `MainActivity`, yes.

We have chaos of forks:

  1. This original one
  2. Mine on GitHub (initially for the rebranded Play Store presence)
  3. Yours on GitHub (as fork of my fork)
  4. Mine on NotABug (form the original one)
  5. ... (Bixilon's etc.)

Shouldn't we move back to one single platform? May you merge my changes you like from 2. into 3. into your information-board changes and afterwards merge our finalized changes into 1.'s master/seperate branch? This amount of different remotes using different versions makes development quite uneasy.

What do you think @fynngodau?

We have chaos of forks: 1. This original one 2. Mine on GitHub (initially for the rebranded Play Store presence) 3. Yours on GitHub (as fork of my fork) 4. Mine on NotABug (form the original one) 5. ... (**Bixilon**'s etc.) Shouldn't we move back to one single platform? May you merge my changes you like from **2.** into **3.** into your *information-board* changes and afterwards merge our finalized changes into **1.**'s master/seperate branch? This amount of different remotes using different versions makes development quite uneasy. What do you think @fynngodau?

Oh no... I will still merge your pull request on my GitLab and afterwards you'll decide what to keep.

**Oh no...** I will still merge your pull request on my GitLab and afterwards you'll decide what to keep.
fynngodau commented 4 years ago
Owner

Well, it was you who pushed the information-board branch into your GitLab remote, so to open a pull request, I had to create a fork there too.

At the moment I have nice-looking support for multiple images, but displaying so few images that they are less wide than the screen is (such as just one image) looks bad because of the empty space next to it and I don't know what I should do about that. I believe it would be Material Design to zoom them until they fit, but that would be a cruel thing to do, more so because the images often contain text. I could alternatively simply center it?

(Right now your latest commit causes a merge conflict with my branch, but if your latest commit was removed it would apply cleanly again.)

Well, it was you who pushed the `information-board` branch into your GitLab remote, so to open a pull request, I had to create a fork there too. At the moment I have nice-looking support for multiple images, but displaying so few images that they are less wide than the screen is (such as just one image) looks bad because of the empty space next to it and I don't know what I should do about that. I believe it would be Material Design to zoom them until they fit, but that would be a cruel thing to do, more so because the images often contain text. I could alternatively simply center it? (Right now your latest commit causes a merge conflict with my branch, but if your latest commit was removed it would apply cleanly again.)

No do not. I am still fixing a bug in DownloadManager.java@640 causing no notices to be displayed and the layout on large screens. I'll finish in some minutes. Stay tuned!

No do not. I am still fixing a bug in DownloadManager.java@640 causing no notices to be displayed and the layout on large screens. I'll finish in some minutes. Stay tuned!

Anyway, my icon is quite material, if you have a look at the secs on https://material.io/

I would prefer my icon, as I associate yours with a list of check boxes and a newspaper should make clear we are about news.

Anyway, my icon is quite material, if you have a look at the secs on https://material.io/ I would prefer my icon, as I associate yours with a list of check boxes and a newspaper should make clear we are about news.
fynngodau commented 4 years ago
Owner

I wanted to use a newspaper icon too, and I know the one I am using is a bad substitute, but the Material icon collection did not contain any. The icon you are using – and again, where did you get it from? – looks like it doesn't belong.

I wanted to use a newspaper icon too, and I know the one I am using is a bad substitute, but the Material icon collection did not contain any. The icon you are using – and again, where did you get it from? – looks like it doesn't belong.

Maybe one of https://materialdesignicons.com/ (where I am contributor)

Maybe one of https://materialdesignicons.com/ (where I am contributor)
https://materialdesignicons.com/icon/newspaper https://materialdesignicons.com/icon/newspaper-variant-multiple-outline https://materialdesignicons.com/icon/newspaper-variant-multiple
fynngodau commented 4 years ago
Owner

That is the website I was just looking at, the newspaper icon is exactly the icon I was looking for-- why was it made by Google but is not in the Material icon collection?

That is the website I was just looking at, the `newspaper` icon is exactly the icon I was looking for-- why was it made by Google but is not in the Material icon collection?

If you tell me which one you like I'll include it.

If you tell me which one you like I'll include it.

Because they don't publish everything... :smirk:

Because they don't publish everything... :smirk:
fynngodau commented 4 years ago
Owner

Hmm, maybe newspaper is used too much to mean "ad" by these gratis apps you can find on the play store. The newspaper-variant also looks more quiet, so I think we should choose it. Because @Bixilon chose the outline variant of the eye icon, we should also choose the outline variant for this icon.

Hmm, maybe `newspaper` is used too much to mean "ad" by these gratis apps you can find on the play store. The `newspaper-variant` also looks more quiet, so I think we should choose it. Because @Bixilon chose the `outline` variant of the eye icon, we should also choose the outline variant for this icon.

@fynngodau I finished. Will you merge into this server? I will now disactivate my GitLab copy (till I maybe have to reactivate it after Hanover...).

@fynngodau I finished. Will you merge into this server? I will now disactivate my GitLab copy (till I maybe have to reactivate it after Hanover...).
fynngodau commented 4 years ago
Owner

I'm not happy with the look we're getting with these margins. I actually preferred it without it, though I do understand it's hard to tell these images apart then…

I'm not happy with the look we're getting with these margins. I actually preferred it without it, though I do understand it's hard to tell these images apart then…

https://material.io/components/cards/#specs

According to the material design guidelines, padding/margin is necessary.

https://material.io/components/cards/#specs According to the material design guidelines, padding/margin is necessary.
fynngodau commented 4 years ago
Owner

The content (the circle-triangle-thing) displayed in these cards is aligned to the card's border and doesn't have margin.

The content (the circle-triangle-thing) displayed in these cards is aligned to the card's border and doesn't have margin.

Will you quickly change it? I currently can't access my workstation.

Will you quickly change it? I currently can't access my workstation.
fynngodau commented 4 years ago
Owner

Yes, and I will start the merge process now.

Yes, and I will start the merge process now.
fynngodau commented 4 years ago
Owner

I merged it successfully with fc59676a8a, hooray.

I merged it successfully with fc59676a8aeedf3e9b82781ab562087010796443, hooray.

When @bixilon updates the icon, can u create a tag? These two features make a major change.

When @bixilon updates the icon, can u create a tag? These two features make a major change.

?

What icon should I update?

? What icon should I update?
fynngodau commented 4 years ago
Owner

Yes, I too thought we should tag the next version now (which I think would be 2.7).

@JasMich.de I think you have been confused; the eye icon we currently have is the outline one from the Material icon collection.

Yes, I too thought we should tag the next version now (which I think would be `2.7`). @JasMich.de I think you have been confused; the eye icon we currently have is the outline one from the Material icon collection.

New Version: okay. 2.7 (there where big changes) You only need to change the version string, I already count (instantly afer a release). I already tried it with 6e0c89a786.

Currently I get build errors (gradle), but thats an other topic and (probably) not an issue.

New Version: okay. 2.7 (there where big changes) You only need to change the version string, I already count (instantly afer a release). I already tried it with 6e0c89a786. Currently I get build errors (gradle), but thats an other topic and (probably) not an issue.
Sign in to join this conversation.
No Milestone
3 Participants
Loading...
Cancel
Save
There is no content yet.