#5 update to latest base64 from industria

Merged
civodul merged 1 commits from aconchillo/update-base64 into cwebber/master 3 years ago

I'm porting guile-jwt to use gcrypt (instead of industria's). When doing so I realized that guile-gcrypt's base64 also comes from Industria, however it has a very old version.

guile-jwt needed to allow decoding without padding which Göran Weinholt kindly added. This was around 2018. I just saw he added a few more fixes.

So, this is just an update of base64 using latest and greatest.

I'm porting guile-jwt to use gcrypt (instead of industria's). When doing so I realized that guile-gcrypt's base64 also comes from Industria, however it has a very old version. guile-jwt needed to allow decoding without padding which Göran Weinholt kindly added. This was around 2018. I just saw he added a few more fixes. So, this is just an update of base64 using latest and greatest.
aconchillo commented 3 years ago
Poster

Btw, a quick release would be greatly appreciated so I could also publish an updated guile-jwt release... :-D.

Btw, a quick release would be greatly appreciated so I could also publish an updated guile-jwt release... :-D.
civodul commented 3 years ago
Collaborator

Hi!

The change looks good to me, though I'd have one minor request: could you add tests showing decoding without strict padding?

Thanks, and apologies for the delay!

Ludo'.

Hi! The change looks good to me, though I'd have one minor request: could you add tests showing decoding without strict padding? Thanks, and apologies for the delay! Ludo'.
aconchillo commented 3 years ago
Poster

Hi! Just updated the PR with new tests. Thanks!

Hi! Just updated the PR with new tests. Thanks!
This pull request has been merged successfully!
Sign in to join this conversation.
No Label
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.