#8 Add an option to configuration notification check/reminder

Closed
opened 4 years ago by aplufr · 10 comments
aplufr commented 4 years ago

With the latest update coming from f-droid the apps is becoming a bit annoying, as a notification of "a new update of firefox" is pushed almost every-time I look at my phone.

I know I'm still using FF 66.0 while 66.0.5 is out there but being notified 10 times per hour is a bit too much...

So please add an option to configure check interval and notification of new update!

Thanks

With the latest update coming from f-droid the apps is becoming a bit annoying, as a notification of "a new update of firefox" is pushed almost every-time I look at my phone. I know I'm still using FF 66.0 while 66.0.5 is out there but being notified 10 times per hour is a bit too much... So please add an option to configure check interval and notification of new update! Thanks
Tobiwan commented 4 years ago
Owner

I should be more careful what I commit.

FFUpdater should check for an Firefox update + display the notification every 6 hour. For testing I've changed the value to 5 minutes and forgotten to changed it back.

https://notabug.org/Tobiwan/ffupdater/src/master/ffupdater/src/main/java/de/marmaro/krt/ffupdater/MainActivity.java#L69

I will change the value back to 6 hours (or are 9 or 12 hours more appropriate aplufr?).

But is it really worth it to add additional options to configure the update check? It adds more complexity and more complexity will cause bugs.

I should be more careful what I commit. FFUpdater should check for an Firefox update + display the notification every 6 hour. For testing I've changed the value to 5 minutes and forgotten to changed it back. https://notabug.org/Tobiwan/ffupdater/src/master/ffupdater/src/main/java/de/marmaro/krt/ffupdater/MainActivity.java#L69 I will change the value back to 6 hours (or are 9 or 12 hours more appropriate aplufr?). But is it really worth it to add additional options to configure the update check? It adds more complexity and more complexity will cause bugs.
aplufr commented 4 years ago
Poster

Thanks. I believe it's okay with the previous value.

Allowing users to configure the update check might be great but is not priority (but it can prevent issue like this one)

Thanks. I believe it's okay with the previous value. Allowing users to configure the update check might be great but is not priority (but it can prevent issue like this one)
Tobiwan commented 4 years ago
Owner

The update is now online.

I think that you might be right. There could be use cases where a regular update check is not what the user wants. I'm going to look into it in my semester break.

The update is now online. I think that you might be right. There could be use cases where a regular update check is not what the user wants. I'm going to look into it in my semester break.
wah6Me1l commented 4 years ago

I second the idea that the check interval should be configurable, and the option to check updates only manually. For me, the interval being 12 hours is also too short. The intervals between different branches are about 2 months. Although there are minor versions, I think that it is still too frequent to check updates every day.

I second the idea that the check interval should be configurable, and the option to check updates only manually. For me, the interval being 12 hours is also too short. The intervals between different branches are about 2 months. Although there are minor versions, I think that it is still too frequent to check updates every day.
Tobiwan commented 4 years ago
Owner

Ok, I learned my lesson. I thought a "one size fits all" approach (for the "check every x hours for an update") would work - but it doesn't.

I will implement this in the next 1-2 weeks (because of university exams etc.).

Ok, I learned my lesson. I thought a "one size fits all" approach (for the "check every x hours for an update") would work - but it doesn't. I will implement this in the next 1-2 weeks (because of university exams etc.).
Tobiwan referenced this issue from a commit 4 years ago
Tobiwan referenced this issue from a commit 4 years ago
Tobiwan referenced this issue from a commit 4 years ago
Tobiwan referenced this issue from a commit 4 years ago
Tobiwan referenced this issue from a commit 4 years ago
Tobiwan referenced this issue from a commit 4 years ago
Tobiwan referenced this issue from a commit 4 years ago
Tobiwan referenced this issue from a commit 4 years ago
Tobiwan commented 4 years ago
Owner

The feature is now implemented. @aplufr @wah6Me1l do you want to review my changes?

Code: https://notabug.org/Tobiwan/ffupdater/src/improve_automatic_update_checker

App (you have to remove the official FFUpdater-App first because I dont have the signing keys from F-Droid): https://notabug.org/Tobiwan/ffupdater/releases

Screenshots

The feature is now implemented. @aplufr @wah6Me1l do you want to review my changes? Code: https://notabug.org/Tobiwan/ffupdater/src/improve_automatic_update_checker App (you have to remove the official FFUpdater-App first because I dont have the signing keys from F-Droid): https://notabug.org/Tobiwan/ffupdater/releases Screenshots

@Tobiwan I think "Every" word is redundant. Just "15 minutes", "1 hour" etc. are better.

@Tobiwan I think "Every" word is redundant. Just "15 minutes", "1 hour" etc. are better.
Tobiwan commented 4 years ago
Owner

yeah, looks better

yeah, looks better
Tobiwan referenced this issue from a commit 4 years ago

BTW, please, change "Never - Disable automatic update check" to "Never (disable automatic update check)".

BTW, please, change "Never - Disable automatic update check" to "Never (disable automatic update check)".
Tobiwan referenced this issue from a commit 4 years ago
Tobiwan commented 4 years ago
Owner

I created a new version (67.0) containing this code (because I also want to publish a fix for the broken firefox nigthly download https://github.com/Tobi823/ffupdater/issues/2).

But it will take 1-3 days until F-Droid will distribute the new version.

If there is any problem left, please free to open a new issue or reopen this issue.

I created a new version (67.0) containing this code (because I also want to publish a fix for the broken firefox nigthly download https://github.com/Tobi823/ffupdater/issues/2). But it will take 1-3 days until F-Droid will distribute the new version. If there is any problem left, please free to open a new issue or reopen this issue.
Sign in to join this conversation.
Loading...
Cancel
Save
There is no content yet.