#10 Protected Sakura Wood Door introduced

Closed
Zweihorn wants to merge 3 commits from Zweihorn/sakura_door into TenPlus1/master

When ethereal is available one would presume a Protected Sakura Wood Door is introduced in addition to the wood and the steel door respectively.

Unfortunately, I did not check if the code is running on a MT client yet. However, I would presume no issues.

I copied both the ethereal_sakura_door.png and the ethereal_sakura_door_inv.png textures into this mod as this seems appropriate. IMHO these two files and names are independant from the b.m. harmonisation issue.

I hope this is a reasonable Pull request. Any advice would be welcome.

When `ethereal` is available one would presume a *Protected Sakura Wood Door* is introduced in addition to the wood and the steel door respectively. Unfortunately, I did not check if the code is running on a MT client yet. However, I would presume no issues. I copied both the `ethereal_sakura_door.png` and the `ethereal_sakura_door_inv.png` textures into this mod as this seems appropriate. IMHO these two files and names are independant from the b.m. harmonisation issue. I hope this is a reasonable Pull request. Any advice would be welcome.
Zweihorn commented 4 months ago
Poster

Please be aware of a side effect due to the harmonisation of names between the ethereal and the MT game doors mods. You should consider TenPlus1/ethereal#5 before addressing 6fd46e7538

The other two commits before this are independant from the harmonisation issue.

Please be aware of a side effect due to the harmonisation of names between the `ethereal` and the MT game `doors` mods. You should consider https://notabug.org/TenPlus1/ethereal/issues/5 before addressing https://notabug.org/Zweihorn/protector/commit/6fd46e7538622cf9819e4cf53ab6522af2e64689 The other two commits before this are independant from the harmonisation issue.
TenPlus1 commented 4 months ago
Owner

This is one of the reasons I created Doors Redo mod, so that you can use the key-tool to switch doors between open, locked and protected without having to register 3 different doors.

https://notabug.org/TenPlus1/doors

This is one of the reasons I created Doors Redo mod, so that you can use the key-tool to switch doors between open, locked and protected without having to register 3 different doors. https://notabug.org/TenPlus1/doors
Zweihorn commented 4 months ago
Poster

Thank you. So by use of the additional 'doors' mod there is a protected sakura door available?

However, two questions:

  • Could you add a more prominent info about the above to 'protector' please? Or did I miss something obvious?
  • Why does 'protector' still hold the wooden and the steel door when there is the additional 'doors' mod?

Happy hacking.

Thank you. So by use of the additional 'doors' mod there is a protected sakura door available? However, two questions: * Could you add a more prominent info about the above to 'protector' please? Or did I miss something obvious? * Why does 'protector' still hold the wooden and the steel door when there is the additional 'doors' mod? Happy hacking.
TenPlus1 commented 4 months ago
Owner

The Doors Redo mod overrides the default doors and provides a key tool that can be used on any registered door that will switch between open, locked, protected... This means that even wooden and sakura doors can be locked or protected by the user... Protector Redo has separate protected doors incase doors redo isn't in use.

The Doors Redo mod overrides the default doors and provides a key tool that can be used on any registered door that will switch between open, locked, protected... This means that even wooden and sakura doors can be locked or protected by the user... Protector Redo has separate protected doors incase doors redo isn't in use.
Please reopen this pull request to perform merge operation.
Sign in to join this conversation.
No Label
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.