#2 Improve empty bucket removal when milking cows

Closed
12Me21 wants to merge 1 commits from 12Me21/master into TenPlus1/master
12Me21 commented 2 years ago

A bucket will be removed from the wielded itemstack, rather than from any slot in the "main" inventory list.

This is consistent with how the mobs API handles other things like removing the item used to feed animals (see https://notabug.org/TenPlus1/mobs_redo/src/master/api.lua#L3752)

It solves the problem of buckets being duplicated in the feedlot mod's milker (https://forum.minetest.net/viewtopic.php?f=9&t=18811).

(I'm not sure whether the empty bucket should still be removed in creative mode, but the buckets mod acts the same way)

A bucket will be removed from the wielded itemstack, rather than from any slot in the "main" inventory list. This is consistent with how the mobs API handles other things like removing the item used to feed animals (see https://notabug.org/TenPlus1/mobs_redo/src/master/api.lua#L3752) It solves the problem of buckets being duplicated in the feedlot mod's milker (https://forum.minetest.net/viewtopic.php?f=9&t=18811). (I'm not sure whether the empty bucket should still be removed in creative mode, but the buckets mod acts the same way)
TenPlus1 commented 2 years ago
Owner

added with changes :) thanks

added with changes :) thanks
Please reopen this pull request to perform merge operation.
Sign in to join this conversation.
No Label
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.