#13 delete redundant config line in `farming.conf_example`

Closed
Zweihorn wants to merge 1 commits from Zweihorn/conf_tidy into TenPlus1/master

sic

sic
TenPlus1 commented 10 months ago
Owner

that line is still needed as a custom fallback value.

that line is still needed as a custom fallback value.
Zweihorn commented 10 months ago
Poster

Please reconsider which line out of the two identical lines to delete.

This closing seems to be a misunderstanding. The line is redundant as you do repeat it in the same file. Have a look into the original farming.conf_example file please. The content of line 32 is repeated in line 36 with the same content farming.rarety = 0.002 as:

farming.grains = true -- true or false only
farming.rarety = 0.002

-- default rarety of crops on map (higher number = more crops)
farming.rarety = 0.002

I am neutral on which line out of the two identical lines to delete. IMHO one line of farming.rarety = 0.002 is sufficient. Two lines can be called redundant and could lead to errors. Or am I wrong?

Please reconsider which line out of the two identical lines to delete. This closing seems to be a misunderstanding. The line is redundant as you do repeat it in the same file. Have a look into the original [farming.conf_example](https://notabug.org/TenPlus1/farming/src/master/farming.conf_example) file please. The **content** of *line 32* **is repeated** in *line 36* with the same content `farming.rarety = 0.002` as: ``` farming.grains = true -- true or false only farming.rarety = 0.002 -- default rarety of crops on map (higher number = more crops) farming.rarety = 0.002 ``` I am neutral on which line out of the two identical lines to delete. IMHO one line of `farming.rarety = 0.002` is sufficient. Two lines can be called redundant and could lead to errors. Or am I wrong?
TenPlus1 commented 10 months ago
Owner

Oops, I assumed you meant to remove that setting entirely :P I didn't realise I had two identical lines inside that file... ehehe

Oops, I assumed you meant to remove that setting entirely :P I didn't realise I had two identical lines inside that file... ehehe
Zweihorn commented 10 months ago
Poster

+1 :)

+1 :)
Please reopen this pull request to perform merge operation.
Sign in to join this conversation.
No Label
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.