#20 Make vendor machines work with hopper

Open
opened 2 months ago by MisterE123 · 7 comments

Make vendor machines work with hopper like a chest so that automatic store factories can be built

Willing to have this assigned to me, would submit a PR

Make vendor machines work with hopper like a chest so that automatic store factories can be built Willing to have this assigned to me, would submit a PR
MeseCraft commented 2 months ago
Owner

Yep, that is something I thought about as well.

I was considering adding pipeworks.

I choose to use fancyvend again because it had compatibility for pipeworks and digilines. But if you want to go ahead and add compatibility for hoppers, that might be the way to go.

I haven't added pipeworks again because i am still unsure about some of the nodes in it and how they will affect the game. Particularly, I'm concerned about the water nodes.But I could always remove those. I see no harm in adding support for hoppers/chutes so if that is something you wish to do, please feel free.

Yep, that is something I thought about as well. I was considering adding pipeworks. I choose to use fancyvend again because it had compatibility for pipeworks and digilines. But if you want to go ahead and add compatibility for hoppers, that might be the way to go. I haven't added pipeworks again because i am still unsure about some of the nodes in it and how they will affect the game. Particularly, I'm concerned about the water nodes.But I could always remove those. I see no harm in adding support for hoppers/chutes so if that is something you wish to do, please feel free.
MisterE123 commented 2 months ago
Poster

I think it might be better to add nodes that support hoppers. Pipeworks is bloated. It also will make infinite automation very easy. Hoppers fits the game better, I think

I think it might be better to add nodes that support hoppers. Pipeworks is bloated. It also will make infinite automation very easy. Hoppers fits the game better, I think
MisterE123 commented 2 months ago
Poster

and we can add nodes like deployer and breaker, if desired, without too much coding. We can use the pipeworks versions perhaps.

and we can add nodes like deployer and breaker, if desired, without too much coding. We can use the pipeworks versions perhaps.
MisterE123 commented 2 months ago
Poster

on second thought, would it be alright If I just told you how to change the code? making a PR seems excessive for the work involved, as only a few lines of code need to be added

on second thought, would it be alright If I just told you how to change the code? making a PR seems excessive for the work involved, as only a few lines of code need to be added
MeseCraft commented 2 months ago
Owner

Sure, just post a segment here and describe the snippet. I'd prefer to not need pipeworks, as I agreee that it might have some bloat. I really hate how it adds the ports on chests and furnaces and I think that is confusing to new players.

Sure, just post a segment here and describe the snippet. I'd prefer to not need pipeworks, as I agreee that it might have some bloat. I really hate how it adds the ports on chests and furnaces and I think that is confusing to new players.
MisterE123 commented 2 months ago
Poster

at the end of https://notabug.org/MeseCraft/mesecraft/src/master/mods/ITEMS/fancy_vend/init.lua

add:

hopper:add_container({{"top", "fancy_vend:player_vendor", "main"}}),
hopper:add_container({{"top", "fancy_vend:player_depo", "main"}}),
hopper:add_container({{"top", "fancy_vend:admin_vendor", "main"}}),
hopper:add_container({{"top", "fancy_vend:admin_depo", "main"}}),

and ofc add hopper to fancy_vend 's dependencies

that means that the hopper will take items out of the bottom of a vending machine (if you put the hopper below the vending machine)

at the end of https://notabug.org/MeseCraft/mesecraft/src/master/mods/ITEMS/fancy_vend/init.lua add: ```lua hopper:add_container({{"top", "fancy_vend:player_vendor", "main"}}), hopper:add_container({{"top", "fancy_vend:player_depo", "main"}}), hopper:add_container({{"top", "fancy_vend:admin_vendor", "main"}}), hopper:add_container({{"top", "fancy_vend:admin_depo", "main"}}), ``` and ofc add hopper to fancy_vend 's dependencies that means that the hopper will take items out of the bottom of a vending machine (if you put the hopper below the vending machine)
MisterE123 commented 2 months ago
Poster

on the server Yourland, pipeworks has been a headache's worth cause of lag

on the server Yourland, pipeworks has been a headache's worth cause of lag
Sign in to join this conversation.
No Label
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.